Skip to content

MNTP: Re-initialize contextual dialog options upon content creation#17301

Merged
Zeegaan merged 1 commit intov13/devfrom
v13/fix/dynamic-root-reload-for-new-content
Oct 18, 2024
Merged

MNTP: Re-initialize contextual dialog options upon content creation#17301
Zeegaan merged 1 commit intov13/devfrom
v13/fix/dynamic-root-reload-for-new-content

Conversation

@kjac
Copy link
Contributor

@kjac kjac commented Oct 17, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #15770 (in part)

Description

Notice that #15770 covers two different issues:

  • The original issue description.
  • Other contextual issues for newly created content, raised in this comment.

This PR fixes the issue described in the original issue description by reloading the contextual dialog options, if the MNTP is part of a newly created document.

Another PR will be submitted to tackle the other contextual issues, as they are indeed a whole other issue.

Testing this PR

Follow the steps in the issue description in #15770 - it should work now after content creation.

Please notice that the screencast in the first comment of #15770 is somewhat off; it does not follow the steps, so don't follow the screencast when testing 😆

@Zeegaan
Copy link
Member

Zeegaan commented Oct 18, 2024

Looks good, tests good 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants