Skip to content

Enrich the datatype references output with content type data#16417

Merged
kjac merged 1 commit intov14/devfrom
v14/fix/add-content-type-to-datatype-reference
May 27, 2024
Merged

Enrich the datatype references output with content type data#16417
kjac merged 1 commit intov14/devfrom
v14/fix/add-content-type-to-datatype-reference

Conversation

@kjac
Copy link
Contributor

@kjac kjac commented May 27, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

🚨 Do not merge this until the client is ready 🚨

The datatype references output is very limited. If it is to be utilized as-is, it will require a lot of additional API requests to create meaningful UI on top.

The corresponding references outputs for document and media types have been enriched with these data, so it seems fitting to do it for datatypes also.

NOTE: The type property in the datatype references output has moved into the new contentType property.

Testing this PR

Fetch references for a datatype that is used on a doc/media/member type. Verify that the new output format contains the doc/media/member type name and icon.

Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good 🚀

@kjac kjac merged commit 5296013 into v14/dev May 27, 2024
@kjac kjac deleted the v14/fix/add-content-type-to-datatype-reference branch May 27, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants