Use runtime mode to determine cache TTL for manifest files#16393
Merged
Use runtime mode to determine cache TTL for manifest files#16393
Conversation
Migaroez
approved these changes
May 27, 2024
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
Code looks good, works as described 🚀
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Currently the
umbraco-package.jsonfiles are read and cached with a configurable TTL (set inPackageManifestSettings). In principle this is fine... but in reality, devs won't realize the TTL option and be annoyed by having to restart the site whenever they make changes to the manifest files.This PR bases the cache TTL on the current runtime mode, effectively only caching manifests in
Productionmode (in the other runtime modes, the manifests are cached for 10 seconds to avoid re-reading the manifests twice when the client requests public and private manifests in rapid succession).The
PackageManifestSettingshave been introduced as part of V14, and currently it only controls the cache TTL, so I have remove it (we can always re-introduce it later if the need arises). Therefore, this PR is breaking, but only against the previous V14 RCs 😄Testing this PR
Use Swagger to fetch the manifests (reach out to @kjac if you need a manifest for testing). Make a change to a manifest, wait a few seconds and fetch the manifests again. The changed manifest should be reflected in the output.