Merged
Conversation
Migaroez
requested changes
May 23, 2024
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
Works as described, code looks ok ✅
Todo: cleanup license file commit
Optional: add a unittest for the delete behaviour?
Contributor
Author
There was a problem hiding this comment.
Geez. That explains why Git was complaining so much ... thanks 🤦 it's been removed.
Contributor
Author
|
There is a test for the delete behavior 😄 https://github.com/umbraco/Umbraco-CMS/pull/16343/files#diff-0603ca1f3e26b7b478be4d08bca0fae507da4ddadbb0f1f1c00e6e7859d37160R226-R235 |
Migaroez
approved these changes
May 23, 2024
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
After being blind on both ends, seems to be in a good state now 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The core is depending on having certain media types available - the "system" media types (File, Folder, Image). Whilst not ideal, this is the current state of the core.
We need to ensure that these are not deleted or have their alias changed.
The V13 approach was purely client-side. This is enabled by this PR for V14 by adding
IsDeletableandAliasCanBeChangedproperties to the relevant media type endpoints.Additionally, this PR ensures that we do not accept critical changes to the system media types at service level.
Testing this PR
The media type tree endpoints should list the system media types as non-deletable (
IsDeletable == false).The "by ID" endpoint should also list the system media types as non-deletable, and also non-alias-changeable 😆 (
AliasCanBeChanged == false).