The preview hub throws an exception during DB upgrade#16338
Merged
Conversation
Member
|
Looks good, tests good 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The preview hub sometimes throws an exception when upgrading a DB:
I can't entirely put my finger on when and why, but it has to do with content cache refreshing at the end of the upgrade process:
This PR adds a little extra logic to the preview hub, so it strictly only handles "refresh node" notifications.
Testing this PR
To test that the upgrade works, get in touch with @kjac for a test DB which will trigger the cache refresh during upgrade.
Also test that the preview hub actually triggers updates when saving content. It's likely easiest to verify this using a debugger.