merge user/current/logins and user/current/login-providers#16307
Merged
iOvergaard merged 1 commit intov14/devfrom May 17, 2024
Merged
merge user/current/logins and user/current/login-providers#16307iOvergaard merged 1 commit intov14/devfrom
iOvergaard merged 1 commit intov14/devfrom
Conversation
also deleted unused requestmodel
iOvergaard
approved these changes
May 17, 2024
Contributor
iOvergaard
left a comment
iOvergaard
left a comment
There was a problem hiding this comment.
Tested it out and it works well!
iOvergaard
added
release/14.0.0-rc4
and removed
project/bellissima
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
There are currently 2 endpoints that return information about login providers.
Since our DB model only supports 1 login per provider per user, we can merge these endpoints reducing a call by the frontend.
Also deleted an unused request model.
Breaking information
Removing the /user/current/logins is technically breaking between the RC's but since this endpoint is most likely not used by implementors, it is considered safe to remove.
Testing