Skip to content

[V14] Allow specifying ID on the create package endpoint#16203

Merged
Zeegaan merged 3 commits intov14/devfrom
v14/fix/package-id
May 2, 2024
Merged

[V14] Allow specifying ID on the create package endpoint#16203
Zeegaan merged 3 commits intov14/devfrom
v14/fix/package-id

Conversation

@Migaroez
Copy link
Contributor

@Migaroez Migaroez commented May 2, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Allowing to specify the ID on the create package endpoint aligns it with the rest of our create endpoints

Testing

  • Validate whether a chosen ID is respected in the response headers and the resource can be fetched.
  • Validate the ID is optional and a random one will be assigned if not supplied

Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good! 💯
Will merge when tests are done 😁

@Zeegaan Zeegaan merged commit 2009989 into v14/dev May 2, 2024
@Zeegaan Zeegaan deleted the v14/fix/package-id branch May 2, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants