Set the data type editor UI aliases at install time#16185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This is the install equivalent to #16183
Currently, all data types have missing icons on a freshly installed V14:
...despite them seemingly being correctly configured when edited:
This PR ensures that all data types are created with their correct editor UI aliases, thus ensuring that the icons are correct from the get-go:
☝️ As with #16183, this PR sets also the list view editor UI alias to "Umb.PropertyEditorUi.Collection" as a preemptive measure, because this is what it will be eventually on the client (it is currently "Umb.PropertyEditorUi.CollectionView", which is wrong). Thus the list view icons might not show up correctly, depending on when you test this.
Testing this PR
Spin up a brand new V14 database and verify that all data types (possibly except the list view ones) have correct icons in the tree.