Skip to content

V14: Allow file uploads when save and publishing#16153

Merged
kjac merged 1 commit intov14/devfrom
v14/bugfix/allow-file-uploads
Apr 26, 2024
Merged

V14: Allow file uploads when save and publishing#16153
kjac merged 1 commit intov14/devfrom
v14/bugfix/allow-file-uploads

Conversation

@Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Apr 25, 2024

Notes

  • There was a bug that did not allow us to save and publish a document, when you had uploaded a file to a file upload field.
  • This was because the TemporaryFileUploadValidator would fail validation for the temporary file, as it would fail when contentSettings.IsFileAllowedForUpload(extension) was true, which is the wrong way around 🙈 This has been remedied by checking if its false instead 😛

How to test

  • Create a document type, with a file upload property
  • Try to create some content with that document type, make sure to upload an image (jpg for example)
  • Save and publish, this should now no longer yield errors 😁

Image I used for testing:
Shirokuma Cafe full 1192683

@Zeegaan Zeegaan changed the title V14: Allow file uploads V14: Allow file uploads when save and publishing Apr 25, 2024
@kjac kjac merged commit fcbfecd into v14/dev Apr 26, 2024
@kjac kjac deleted the v14/bugfix/allow-file-uploads branch April 26, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants