Make public access endpoints work correctly#16136
Merged
Conversation
Migaroez
approved these changes
Apr 25, 2024
Contributor
Migaroez
left a comment
There was a problem hiding this comment.
Looks good, works as described
| await _publicAccessService.GetEntryByContentKeyAsync(id); | ||
|
|
||
| if (accessAttempt.Success is false) | ||
| if (accessAttempt.Success is false || accessAttempt.Result is null) |
Contributor
There was a problem hiding this comment.
Unless I read this wrong this means that
- it is possible for the attempt to succeed without a result
- if it does, we return a 500
That's the goal?
Contributor
Author
There was a problem hiding this comment.
The latter ShouldNotHappen™ but the Result is a nullable value, so -- need a null check for the compiler to stop complaining.
Contributor
There was a problem hiding this comment.
ShouldNotHappen™ => 500 sounds good to me. Merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
There are a few issues with the "get" and "create" endpoints for public access.
Create
/document/[document key]/public-access.GET
IMembertoMemberItemResponseModel.MemberItemResponseModelthat contains all existing member groups instead of none.Testing this PR
Use Swagger to ensure that the public access endpoints work as expected.