Handle sensitive properties in the Management API#15936
Merged
Conversation
Migaroez
reviewed
Mar 25, 2024
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
Redid the tests and one thing to consider about code location.
Works as described 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds sensitive property handling to the Management API.
Testing this PR
Create members with sensitive properties. You'll need a V13 to do this - and a subsequent migration of the V13 database to test the rest.
As a user with the "Sensitive data" user group assigned, the sensitive properties should be visible and editable through the Management API.
As a user without the "Sensitive data" user group assigned, the sensitive properties should not be visible nor editable through the Management API. In fact, the API should yield an error if attempts are made to hack the API (read: pass in property aliases that match a sensitive property)