Add additional lock timeouts and clean-up ObjectCacheAppCache#15911
Merged
Add additional lock timeouts and clean-up ObjectCacheAppCache#15911
ObjectCacheAppCache#15911Conversation
ronaldbarendse
commented
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends PR #15902 with additional lock timeouts in
SearchByPredicate()when entering the upgradable read lock and inClear()when taking the write lock. The timeout exception messages are also updated to clearly state when it occurred, which should make debugging easier.I've also cleaned up the constructor, as that still had the
IHostEnvironmentparameter (kept in PR #15173 to maintain backwards compatibility, but this got merged to v14, so can be breaking now).