Skip to content

V14: Fix FIXMEs#15869

Merged
Zeegaan merged 8 commits intov14/devfrom
v14/feature/update-denylocalloginhandler
Mar 14, 2024
Merged

V14: Fix FIXMEs#15869
Zeegaan merged 8 commits intov14/devfrom
v14/feature/update-denylocalloginhandler

Conversation

@Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Mar 12, 2024

Notes

  • There was a FIXME in DenyLocalLoginHandler, this should now be resolved 😁

How to test

  • Assert that you can login and out of the backoffice.

@Zeegaan
Copy link
Member Author

Zeegaan commented Mar 12, 2024

I am unsure if this was the correct way to do it, as the other implementation overwrote the IsAuthorized 🤔

@elit0451
Copy link
Contributor

The way to test it is to set isDenied = true; in DenyLocalLoginHandler and verify that you will not be allowed to login (you'll get unauthorized); when it is false, the login/swagger auth should work as normal. We also verified that you can signout - we were getting 401 with the new changes.

@Zeegaan
Copy link
Member Author

Zeegaan commented Mar 14, 2024

Thanks for the assistance on this one @elit0451 🙌 🎉

@Zeegaan Zeegaan merged commit 9c3bc4a into v14/dev Mar 14, 2024
@Zeegaan Zeegaan deleted the v14/feature/update-denylocalloginhandler branch March 14, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants