Removed "type" from tree item response models#15862
Merged
nikolajlauridsen merged 1 commit intov14/devfrom Mar 15, 2024
Merged
Conversation
nikolajlauridsen
approved these changes
Mar 15, 2024
Contributor
nikolajlauridsen
left a comment
nikolajlauridsen
left a comment
There was a problem hiding this comment.
Looks good, and the API does indeed seem to work as usual 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR removes the "type" property of tree item response models in the Management API. It has long since been decided that this property was a client concern, so we need to remove it for clarity.
Breaking change
This PR modifies the current API contract, thus it is breaking 👍
Testing this PR
The Management API should work as per usual 😄