Skip to content

Update documentation for GetAllContentTags method in ITagQuery interface#15860

Merged
georgebid merged 1 commit intoumbraco:contribfrom
BishalTimalsina12:contrib
Mar 12, 2024
Merged

Update documentation for GetAllContentTags method in ITagQuery interface#15860
georgebid merged 1 commit intoumbraco:contribfrom
BishalTimalsina12:contrib

Conversation

@BishalTimalsina12
Copy link
Contributor

@BishalTimalsina12 BishalTimalsina12 commented Mar 11, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes <!-- link to the issue here! -->

Description

@github-actions
Copy link

github-actions bot commented Mar 11, 2024

Hi there @BishalTimalsina12, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @BishalTimalsina12, thanks a lot for your PR to fix #15707 😄 someone on the Core Collaborators team will review this soon!

@georgebid georgebid self-assigned this Mar 11, 2024
@georgebid georgebid self-requested a review March 11, 2024 13:13
@georgebid georgebid merged commit d8b0616 into umbraco:contrib Mar 12, 2024
@georgebid
Copy link
Contributor

Hey @BishalTimalsina12, thanks again for your PR. I have taken a look at your fix and the referenced bug, and I am happy that your comment update meets the requirements of the bug, and therefore I've merged this one in!

I've also noticed that this is your first PR for the Umbraco CMS solution, congrats! 🥳 If you provide us with your account name on the forum, we will gladly assign our shiny contributor's badge to you 🏅

@BishalTimalsina12
Copy link
Contributor Author

BishalTimalsina12 commented Mar 12, 2024

Hiii @georgebid,

Thank you so much for merging my PR and for the recognition! My forum account name is Bishal Tim. Looking forward to receiving the contributor's badge. Thanks again!

@nul800sebastiaan nul800sebastiaan added community/pr release/no-notes Not directly part of the release (updating README, build scripts, tests, etc.) labels Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community/pr release/no-notes Not directly part of the release (updating README, build scripts, tests, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants