V14: Add additional validation around manipulating groups#15834
Merged
V14: Add additional validation around manipulating groups#15834
Conversation
…onal-usergroup-validation
bergmania
requested changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds additional validation around manipulating user groups, more specifically it ensures that the admin group is never left empty, since this would mean that no user could ever be added to the admin group again.
Most of this is pretty run-of-the-mill, however, there was a little snafu with the
UpdateUserGroupsUserController, since this more or less acts more like a UserGroup controller, I've left a clarifying comment in the top of the file.Testing
Ensure that you are not allowed to remove all users from the admin group.