Add ancestor endpoints and remove explicit parent context#15746
Merged
Add ancestor endpoints and remove explicit parent context#15746
Conversation
…, scripts, static files, stylesheets and templates
# Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/FolderManagementControllerBase.cs # src/Umbraco.Cms.Api.Management/OpenApi.json
# Conflicts: # src/Umbraco.Cms.Api.Management/OpenApi.json
# Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/Tree/FolderTreeControllerBase.cs
# Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/Tree/FolderTreeControllerBase.cs
# Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/Dictionary/Tree/DictionaryTreeControllerBase.cs
Contributor
|
Client Part is ready to merge. Please merge this PR umbraco/Umbraco.CMS.Backoffice#1429 when this is merged. |
4 tasks
Migaroez
approved these changes
Mar 25, 2024
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
Looks good (except for the reworked test)
Tests show no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
We need to know about ancestors in the Management API - among other things because:
We already have a few explicit implementations of parent context, but it is not something we have added on a broad scale, so we have opted to remove them in favor of using the ancestor endpoints instead.
The client needs these endpoints to contain the queried item too (the "self"), so that's what they do. Eventually we may add a parameter to make this behavior configurable from the client perspective, but that's for another day.
Testing this PR
Create structures to match the new ancestor endpoints, and use Swagger to query ancestors through these structures. The result should contain the queried item but not the system root (-1).