When Embedding tweets sometimes get Unexpected exception

[Eaglef90]

Which Umbraco version are you using?

16.4

Bug summary

When I try to embed a tweet in an RTE using the built-in Embed function, it randomly fails, no matter which tweet I choose, with an “Unexpected exception happened while trying to get oembed markup” error. I am using the TinyMCE package on my v16 install, so I don’t know if this is a core issue, a package issue, or a Twitter issue, but what was happening every few weeks is now happening almost daily to me and it is blocking articles from getting published.

Specifics

URLs trying to embed:

https://x.com/THR/status/1995620384344080849?s=20
https://x.com/SquareEnix/status/1995780120888705216?s=20
https://x.com/sem_sep/status/1991750339427700739?s=20
https://x.com/sem_sep/status/1991749404114767914?s=20

Error generated:

`System.Text.Json.JsonException: 'e' is an invalid start of a value. Path: $ | LineNumber: 0 | BytePositionInLine: 0.

---> System.Text.Json.JsonReaderException: 'e' is an invalid start of a value. LineNumber: 0 | BytePositionInLine: 0.

at System.Text.Json.ThrowHelper.ThrowJsonReaderException(Utf8JsonReader& json, ExceptionResource resource, Byte nextByte, ReadOnlySpan`1 bytes)

at System.Text.Json.Utf8JsonReader.ConsumeValue(Byte marker)

at System.Text.Json.Utf8JsonReader.ReadFirstToken(Byte first)

at System.Text.Json.Utf8JsonReader.ReadSingleSegment()

at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, T& value, JsonSerializerOptions options, ReadStack& state)

This happens on multiple computers using different browsers on different ISPs (I have tried it from my laptop on my T-Mobile hotspot, my laptop at home on a Fiber connection, and my employee gets it from their desktop at their home on the other side of the USA)

--- End of inner exception stack trace ---

at System.Text.Json.ThrowHelper.ReThrowWithPath(ReadStack& state, JsonReaderException ex)

at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, T& value, JsonSerializerOptions options, ReadStack& state)

at System.Text.Json.JsonSerializer.ReadFromSpan[TValue](ReadOnlySpan1 json, JsonTypeInfo1 jsonTypeInfo)

at Umbraco.Cms.Infrastructure.Serialization.SystemTextJsonSerializerBase.Deserialize[T](String input)

at Umbraco.Cms.Core.Media.EmbedProviders.OEmbedProviderBase.GetJsonResponseAsync[T](String url, CancellationToken cancellationToken)

at Umbraco.Cms.Core.Media.EmbedProviders.OEmbedProviderBase.GetJsonBasedMarkupAsync(String url, Nullable1 maxWidth, Nullable1 maxHeight, CancellationToken cancellationToken)

at Umbraco.Cms.Core.Media.EmbedProviders.X.GetMarkupAsync(String url, Nullable1 maxWidth, Nullable1 maxHeight, CancellationToken cancellationToken)

at Umbraco.Cms.Core.Services.OEmbedService.GetMarkupAsync(Uri url, Nullable1 maxWidth, Nullable1 maxHeight, CancellationToken cancellationToken)`

Steps to reproduce

In the RTE, click the "embed" function from the toolbar menu.
Enter one of the URLs provided
Click "retrieve"
Get error

Expected result / actual result

I would expect the function to work and return the proper code and embed the tweet vs. throwing errors.

[github-actions]

Hi there @Eaglef90!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[AndyButland]

I could replicate consistent rather than intermittent failures with this, as described in the linked PR: #21053

If using the old twitter.com domain for embed retrieval is the cause of the issue you've found, we'll resolve this for 16.5 and 17.1. Meantime you could create your own X embed provider, using the updated code from the PR, and register your own one in place of the one we ship with Umbraco.

[Eaglef90]

Glad you could replicate it. I am not sure what you mean by "using old twitter.com" my employee is on vacation for the next week and a half so this will not be an issue again till he returns. Is there an ETA on 6.5? I am supper busy with things so don't really have time to build my own embed provider right now

[AndyButland]

16.5 we have scheduled for 22nd January, with the release candidate available a couple of weeks before that.