Multi site url tracker ignores domainRootId

[ThiemeH]

Which Umbraco version are you using?

16.3.4

Bug summary

Hi there,

We are currently migrating a project from v10 to v16, and I am running into a critical bug in the url redirect tracker.
The issue is that the redirect tracker does NOT include the domainRootId when writing to the database. In a multi site setup, where multiple domains are used, will this result in all original urls using the hostname of the CMS.

Please note that this wasn't an issue in v10.

Specifics

No response

Steps to reproduce

You can reproduce this issue by:

1. Cloning the main branch of this repo
2. Set UrlProviderMode to Absolute in the development appsettings
3. Create a basic multi site setup as seen below (give both sites an original hostname)
4. Publish all content
5. Rename one of the content of a website

Expected result / actual result

Expected behaviour is that the original url should also contain the correct hostname:

The only way I made this work is by manually adding the domainRootId in the database entry

RedirectTrackingHandler.cs is the starting point for this
RedirectTracker.cs is where the redirect is created

[github-actions]

Hi there @ThiemeH!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[AndyButland]

Thanks for the report @ThiemeH. I've been able to replicate and think I've located the cause of the problem, which I've addressed in #20900. It'll be reviewed internally now and considered for including in an upcoming release.