[V16] Non variant property not disabled in other languages than default one

[Didier-Marin]

Which Umbraco version are you using?

16.2.0

Bug summary

When I create a property non variant, I can still update its value in other languages than the default one.

While in V13 (13.9.2), the property in other languages than the default one was readonly

Specifics

No response

Steps to reproduce

in a multilanguage site (EN as default language + other languages):
In a document type that allows "Vary by culture", add a new property non variant
create a content with this document type
define a value for the non variant property
switch language, the value is available for editing

Expected result / actual result

When a property is non variant in a variant document, it should not be editable in other languages than the default one.

---

This item has been added to our backlog AB#57146

[github-actions]

Hi there @Didier-Marin!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[AndyButland]

I think this may be expected behaviour @Didier-Marin, depending on what you have for this setting: https://docs.umbraco.com/umbraco-cms/reference/configuration/contentsettings#allow-edit-invariant-from-non-default

Please could you review and either report back if you do feel there's a problem, or close the issue you've created if when adjusting the setting you can get the behaviour you want?

[Didier-Marin]

here are my settings

And the property is still editable in other languages than the default one.

[simonech]

Hi @AndyButland, @Didier-Marin is a colleague of mine that is filling in while I'm off.
Indeed, we have it disabled and still shows as editable. In properties, but also the structure of a BGE (with block level variants) and also non-variant properties inside variant blocks

[AndyButland]

Could you also please confirm @Didier-Marin if the user you are accessing with has rights to edit in the default language? If so, I would expect to be able to edit in that case even if AllowEditInvariantFromNonDefault is false.

If the user doesn't have access to the default language, then does sound like a problem we need to investigate.

[Didier-Marin]

Hi @AndyButland , this happens either with an admin profile or just an editor profile (which does not have access to settings section)
All users/profiles can edit all languages, but in V13, with the same profiles, a non variant property is only editable in the default language

[AndyButland]

OK, so I think you are describing expected behaviour. In the docs we say:

When the AllowEditInvariantFromNonDefault setting is set to false (default) the invariant properties can only be edited and published from the default language. This means you need access to the default language in order to edit the property.

So if your editor has access to edit the default English language, it seems correct to me that they can edit the non variant property when editing a non-default language. It would only be if they didn't have access to edit English that this is restricted.

Maybe this behaviour changed since 13 - I'm not sure and will check with the team. But as it stands, it seems correct (at least aligning with how we document the behaviour).

[Didier-Marin]

from what you see, it's not correct :
When the AllowEditInvariantFromNonDefault setting is set to false (default) the invariant properties can only be edited and published from the default language

so editable only from the default language, not from another

It's not because you have access to the default that you can edit in a non default

[AndyButland]

Sorry @Didier-Marin, you are quite right. Now I've got my reading glasses on, I see your point. I can also reproduce.

[AndyButland]

Have done a little debugging. It seems that the configuration is correctly passed through to the backoffice and a UmbVariantPropertyGuardRule is added via this.propertyWriteGuard.addRule(rule);. This is in #preventEditInvariantFromNonDefault() in UmbDocumentWorkspaceContext. However the shared field is still editable.

Also checked a property value permission that uses a similar mechanism to make a field read-only, and that works as expected.

Reproduction steps:

• Configure Umbraco:CMS:Content:AllowEditInvariantFromNonDefault to be false.
• Create a doc type with an invariant and variant text field.
• Notice that you can edit the invariant field even when editing the non-default language.