added accept ranges support required by safari to play videos #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,9 @@ public override Stream Open() | |||
| cache.SetCacheability(HttpCacheability.Public); | |||
| cache.VaryByHeaders["Accept-Encoding"] = true; | |||
|
|
|||
| // Add Accept-Ranges header to fix videos not playing on Safari | |||
There was a problem hiding this comment.
Is it really that easy?! If, so that's amazing! 😄
There was a problem hiding this comment.
Do we want to make it so that it only applies this header for mp4 files?
There was a problem hiding this comment.
No we'll add it for all. Should be fine.
|
From what information I can find this should cover our needs with this provider. @Jeavon Do you concur? |
|
@JimBobSquarePants looks brilliantly simple, lets merge and try out the pre-release? |
|
There we go! All merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.