Fix ESM import in core package by adding .babelrc and babel-plugin-add-import-extension #732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues from #731.
Here is the codesandbox that implements this https://codesandbox.io/p/github/Shellishack/webpack-esm-sandbox/fork-fix. After adding the babel plugin, core builds for ESM contains ".js" suffix in import clauses. So webpack no longer complains things like:
This might be a fix only for Webpack (I am only familiar with Webpack). May need more testing for Vite, etc.
I am sure if adding a babel plugin in this case would be the most appropriate solution, since it was the building tool that did not include file extensions in imports. Is it a behavior from tsbb causing this issue? LMK what you think.