Add background image option to createTheme() #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-vanderheijden
force-pushed
the
add-background-image-theme-option
branch
from
758be29 to
b0d3da8
Compare
jaywcjlove
added a commit
that referenced
this pull request
Sep 22, 2023
|
@ethan-vanderheijden I agree with this perspective. Adding a background image customizing option next to the color selectors on the theme editor page might not be visually appealing. Thus, I agree that it is unnecessary to include a text box for background image customization on the theme editor page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all READMEs and the theme editor page, I added
backgroundImage: '',to show people that the option exists. I don't think we need a background image customizing option on the theme editor page (a text box would look weird next to the color selectors), but let me know if you think otherwise.