Skip to content

Remove need for users to install conda-lock themselves#1941

Merged
abejgonzalez merged 1 commit intomainfrom
remove-conda-lock-from-docs
Aug 2, 2024
Merged

Remove need for users to install conda-lock themselves#1941
abejgonzalez merged 1 commit intomainfrom
remove-conda-lock-from-docs

Conversation

@abejgonzalez
Copy link
Copy Markdown
Contributor

@abejgonzalez abejgonzalez commented Aug 2, 2024

In addition to making the documentation a little bit easier to follow, this also allows us to bump to newer versions of conda-lock without having to tell users. The main con of this is that it creates a new conda environment locally that is just used for conda-lock. Also bumps conda-lock and the lockfiles.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Copy Markdown
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, SFTM

@abejgonzalez abejgonzalez merged commit 27a3f9a into main Aug 2, 2024
@abejgonzalez abejgonzalez deleted the remove-conda-lock-from-docs branch August 6, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants