Add dependabot to auto-update submodules#1940
Merged
abejgonzalez merged 1 commit intomainfrom Aug 2, 2024
Merged
Conversation
Contributor
|
Will CI run on these PRs? A big limitation with the CIRCT action is that it doesn't run our CI. |
Contributor
Author
|
Yup. It will run the CI by default. |
jerryz123
approved these changes
Aug 2, 2024
Contributor
jerryz123
left a comment
There was a problem hiding this comment.
I'm willing to try this out.
06a8517 to
0f4fdcf
Compare
Contributor
Author
|
Small update to instead ignore selected submodules instead of listing them all out. Merging since this doesn't affect CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this to spawn discussion on how/should we use this to update submodules. I think this is nice, but we should 1. configure how often it checks for things and 2. what it should update v.s. what we should do ourselves. In any case, the PRs that it opens still have to be manually approved (see FireSims PRs from dependabot: https://github.com/firesim/firesim/pulls)
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?