Skip to content

Remove pre-commit#1938

Merged
abejgonzalez merged 1 commit intomainfrom
remove-precommit
Aug 1, 2024
Merged

Remove pre-commit#1938
abejgonzalez merged 1 commit intomainfrom
remove-precommit

Conversation

@abejgonzalez
Copy link
Copy Markdown
Contributor

While pre-commit is nice, we've disabled it from the env.sh and never re-added it. So let's just remove the code since it's dead weight.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez
Copy link
Copy Markdown
Contributor Author

Shouldn't affect CI. Merging.

@abejgonzalez abejgonzalez merged commit 0b8ccfb into main Aug 1, 2024
@abejgonzalez abejgonzalez deleted the remove-precommit branch August 6, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants