Update MultiHarnessBinders to connect differently typed ports + Ignore TLMonitors on DigitalTop scope#1868
Merged
abejgonzalez merged 1 commit intomainfrom Apr 30, 2024
Merged
Conversation
jerryz123
approved these changes
Apr 30, 2024
tymcauley
added a commit
to tymcauley/rocket-chip
that referenced
this pull request
Mar 17, 2025
If a user enables AXI4 Monitors (using `AXI4MonitorBuilder`), they'll get a no-implicit-clock error at this point, which isn't easy to track down. Chipyard worked around a similar problem with TileLink Monitors here: ucb-bar/chipyard#1868
savnastou
pushed a commit
to savnastou/rocket-chip
that referenced
this pull request
Mar 20, 2026
If a user enables AXI4 Monitors (using `AXI4MonitorBuilder`), they'll get a no-implicit-clock error at this point, which isn't easy to track down. Chipyard worked around a similar problem with TileLink Monitors here: ucb-bar/chipyard#1868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portobject might be slightly different from source to sink.TLMonitormight not get an implicit clock from theDigitalTopmodule causing an obscure error during elaboration. This fix isn't needed for the AXI4 ports since there is no AXI4 monitor implementation in RC yet, thus no monitors are created for them.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?