Skip to content

Update MultiHarnessBinders to connect differently typed ports + Ignore TLMonitors on DigitalTop scope#1868

Merged
abejgonzalez merged 1 commit intomainfrom
small-fixes
Apr 30, 2024
Merged

Update MultiHarnessBinders to connect differently typed ports + Ignore TLMonitors on DigitalTop scope#1868
abejgonzalez merged 1 commit intomainfrom
small-fixes

Conversation

@abejgonzalez
Copy link
Copy Markdown
Contributor

@abejgonzalez abejgonzalez commented Apr 30, 2024

  • Fixes issue where MultiHarnessBinders couldn't attach two ports of a different type. This matters cases where a the Port object might be slightly different from source to sink.
  • Fixes case where TLMonitor might not get an implicit clock from the DigitalTop module causing an obscure error during elaboration. This fix isn't needed for the AXI4 ports since there is no AXI4 monitor implementation in RC yet, thus no monitors are created for them.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez self-assigned this Apr 30, 2024
@abejgonzalez abejgonzalez changed the title Small fixes Update MultiHarnessBinders to connect differently typed ports + Ignore TLMonitors on DigitalTop scope Apr 30, 2024
@abejgonzalez abejgonzalez requested a review from jerryz123 April 30, 2024 18:33
@abejgonzalez abejgonzalez merged commit f8651bd into main Apr 30, 2024
@abejgonzalez abejgonzalez deleted the small-fixes branch July 4, 2024 00:34
tymcauley added a commit to tymcauley/rocket-chip that referenced this pull request Mar 17, 2025
If a user enables AXI4 Monitors (using `AXI4MonitorBuilder`), they'll
get a no-implicit-clock error at this point, which isn't easy to track
down. Chipyard worked around a similar problem with TileLink Monitors
here: ucb-bar/chipyard#1868
savnastou pushed a commit to savnastou/rocket-chip that referenced this pull request Mar 20, 2026
If a user enables AXI4 Monitors (using `AXI4MonitorBuilder`), they'll
get a no-implicit-clock error at this point, which isn't easy to track
down. Chipyard worked around a similar problem with TileLink Monitors
here: ucb-bar/chipyard#1868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants