Skip to content

Bump firesim to version with detached build.sbt#1864

Merged
jerryz123 merged 2 commits intomainfrom
fsim-detach
Apr 29, 2024
Merged

Bump firesim to version with detached build.sbt#1864
jerryz123 merged 2 commits intomainfrom
fsim-detach

Conversation

@jerryz123
Copy link
Copy Markdown
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 force-pushed the fsim-detach branch 2 times, most recently from efe6ac6 to 95286ad Compare April 25, 2024 18:22
Copy link
Copy Markdown
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SFTM on cursory review

@jerryz123 jerryz123 merged commit 75f3d46 into main Apr 29, 2024
@jerryz123 jerryz123 deleted the fsim-detach branch April 29, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants