EXT_FILELISTS and EXT_INCDIR APIs for including external verilog projects#1832
EXT_FILELISTS and EXT_INCDIR APIs for including external verilog projects#1832
Conversation
|
FWIW I'm in favor of merging this now. I will soon upstream project integration which demonstrates this feature |
|
Can you sync the VLSI Makefile with this? Would replace |
|
Ah yes, that's a good idea, I'll do that |
|
Thanks. Section 5.10.2 of docs too. |
|
Hmm its not quite the same though.. it looks like CUSTOM_VLOG lets you bypass the chipyard/chisel generators entirely,. How should we rectify this? I assume we want to keep the facility for runner hammer w/o the chisel generators? |
|
If I'm not understanding correctly, aren't you trying to bypass Chipyard/Chisel with this too, for doing simulations? Or are these files that you just append in addition to Chipyard-generated verilog? If it's the latter, then it needs to be appended to |
|
This doesn't bypass chipyard, it just appends additional source files. Adding to VLSI_RTL is correct I think |
abejgonzalez
left a comment
There was a problem hiding this comment.
This LGTM. Two things to note:
- I think you can use this API to auto-generate filelists in elaboration by specifying a
auto-gen.fthat is populated in elaboration. This would be useful for projects like CVA6, NVDLA, IBEX, etc which different configurations of the Verilog incorporate different files. - This isn't supported in FireSim right now (should be trivial to support).
External projects which may not want to provide their sources as a blackbox resource, can instead append to these Makefile variables.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?