Conversation
be9197d to
4800589
Compare
joonho3020
reviewed
Jan 26, 2024
Contributor
joonho3020
left a comment
There was a problem hiding this comment.
Is this to save setup time?
Contributor
Author
Yes, its marginal, but cva6 has an insane number of submoules |
Contributor
Yeah that is very true |
joonho3020
approved these changes
Jan 26, 2024
4800589 to
b3c50f4
Compare
b3c50f4 to
89914e4
Compare
Contributor
|
If they aren't inited by default we should update the submodule README or add a script to clone submodules. |
Contributor
Author
|
Enough submods are init'd to build cva6, which is all we should support IMO. No one is using the other features. Initing the rest of cva6 can be done with the standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?