Skip to content

Add generators/ submodule status check to all Make targets#1718

Merged
jerryz123 merged 2 commits intomainfrom
check-submodule-status
Jan 2, 2024
Merged

Add generators/ submodule status check to all Make targets#1718
jerryz123 merged 2 commits intomainfrom
check-submodule-status

Conversation

@jerryz123
Copy link
Copy Markdown
Contributor

This provides a more useful error for uninitialized submodules.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Copy Markdown
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Can you also add something to the help text then I'll approve.

@jerryz123 jerryz123 requested a review from abejgonzalez January 2, 2024 20:51
@jerryz123 jerryz123 merged commit e6d4fe8 into main Jan 2, 2024
@jerryz123 jerryz123 deleted the check-submodule-status branch January 2, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants