Merged
Conversation
Member
|
I'm glad to see these GitHub actions getting some use. I'm also glad that the factoring of These things should be usable by flows which aren't GitHub Actions, i.e. |
seldridge
reviewed
Dec 1, 2023
jerryz123
reviewed
Dec 5, 2023
|
|
||
| echo "Add extra toolchain collateral to RISC-V install area" | ||
| echo "Add extra toolchain collateral + CIRCT to RISC-V install area" | ||
| git submodule update --init ./conda-reqs/install-circt |
Contributor
There was a problem hiding this comment.
Can we move this submodule to tools? Since the install-circt stuff can be run in a non-conda environment.
jerryz123
reviewed
Dec 5, 2023
jerryz123
requested changes
Dec 5, 2023
Contributor
jerryz123
left a comment
There was a problem hiding this comment.
Since the CIRCT stuff is not conda-specific, I think it can be outside of the conda directory.
jerryz123
reviewed
Dec 7, 2023
jerryz123
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CIRCT community has some scripts to help install updated versions / update versions of CIRCT in repos. This PR is to see how well this works in Chipyard. There are two potential implementations of using these scripts:
EDIT: We decided on #1 since it's shifts the burden of us having to maintain a feedstock to the CIRCT devs who already publish a working version of CIRCT.
Any thoughts?
Side Update: Moves the
env.shgeneration into the conda setup part ofbuild-setup.sh. Thus if a later part of the flow fails you still have aenv.shto diagnose and manually do other parts of the setup.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?