Add HasHarnessInstantiators into MultiHarnessBinder#1674
Merged
abejgonzalez merged 4 commits intomainfrom Dec 4, 2023
Merged
Conversation
abejgonzalez
commented
Nov 30, 2023
abejgonzalez
commented
Nov 30, 2023
generators/chipyard/src/main/scala/harness/MultiHarnessBinders.scala
Outdated
Show resolved
Hide resolved
abejgonzalez
commented
Nov 30, 2023
abejgonzalez
commented
Nov 30, 2023
generators/chipyard/src/main/scala/harness/MultiHarnessBinders.scala
Outdated
Show resolved
Hide resolved
abejgonzalez
commented
Nov 30, 2023
generators/chipyard/src/main/scala/harness/MultiHarnessBinders.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Ready for review. |
jerryz123
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, users should be able to generate arb. RTL in the harness and connect up any clock they want to it (for example to connect up a queue between IOs, debugging loggers, etc). This is supported with current
HarnessBindersbut not withMultiHarnessBindersspecifically because theMulti*version doesn't have access toth: HasHarnessInstantiators. This adds this back to theMultiHarnessBinderwhen it was dropped on the PortAPI changes.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?