Use TARGET instead of PREFIX in /tests Makefile(s)#1647
Merged
raghav-g13 merged 2 commits intomainfrom Nov 6, 2023
Merged
Conversation
Contributor
|
Can you rebase this on master with Abe's new CI changes? Then the tests should all run ... and faster too. |
9deab21 to
54f7237
Compare
abejgonzalez
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: In
/tests, when building libgloss locally, i.e., withBUILD_LIBGLOSS=1,libgloss.mkexpects the variableTARGETto be defined. It uses--host=$(TARGET)for GCC cross-compilation. Currently, this errors out.Fix: Set
TARGETintests/Makefile. Replace the use ofPREFIXwithTARGETso we only have a single source of truth.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?