Skip to content

Use TARGET instead of PREFIX in /tests Makefile(s)#1647

Merged
raghav-g13 merged 2 commits intomainfrom
fix-tests-make
Nov 6, 2023
Merged

Use TARGET instead of PREFIX in /tests Makefile(s)#1647
raghav-g13 merged 2 commits intomainfrom
fix-tests-make

Conversation

@raghav-g13
Copy link
Copy Markdown
Contributor

Issue: In /tests, when building libgloss locally, i.e., with BUILD_LIBGLOSS=1, libgloss.mk expects the variable TARGET to be defined. It uses --host=$(TARGET) for GCC cross-compilation. Currently, this errors out.

Fix: Set TARGET in tests/Makefile. Replace the use of PREFIX with TARGET so we only have a single source of truth.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123
Copy link
Copy Markdown
Contributor

Can you rebase this on master with Abe's new CI changes? Then the tests should all run ... and faster too.

@raghav-g13 raghav-g13 merged commit 29d774a into main Nov 6, 2023
@jerryz123 jerryz123 deleted the fix-tests-make branch January 21, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants