Rebuild jars when sv/v files are changed + Add documentation on blackboxes#1639
Merged
abejgonzalez merged 7 commits intomainfrom Nov 6, 2023
Merged
Rebuild jars when sv/v files are changed + Add documentation on blackboxes#1639abejgonzalez merged 7 commits intomainfrom
jars when sv/v files are changed + Add documentation on blackboxes#1639abejgonzalez merged 7 commits intomainfrom
Conversation
jerryz123
reviewed
Nov 1, 2023
jerryz123
reviewed
Nov 1, 2023
Contributor
Author
|
Testing with |
12 tasks
jars when sv/v files are changed + Add documentation on blackboxes
16 tasks
jerryz123
reviewed
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jargeneration so that Verilog files are properly updated in thejar. This was bugged before since you would have to recompile Scala sources to see the Verilog sources change.includehasincludewithin it, rerun the replacement)generate-conda-lockfilesscript to delete the lockfile before regenerating (fixes issue whereconda-lockwould get stuck regenerating the lockfile if the lockfile pre-existed)It also exposes a bug mentioned here: #1624 (comment). This is an issue in MFC that needs to get solved.
The error being that duplicate
addPathcalls cannot exist (not sure if having a different module name will fix the issue). Error message is the following:Cannot find file /scratch/abejgonza/cy/generators/chipyard/src/main/resources/vsrc/GCDMMIOBlackBox.vRelated PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?