Skip to content

Fix icenet-loopback clock and reset domain#1612

Merged
jerryz123 merged 3 commits intomainfrom
icenet-loopback-fix
Oct 6, 2023
Merged

Fix icenet-loopback clock and reset domain#1612
jerryz123 merged 3 commits intomainfrom
icenet-loopback-fix

Conversation

@joonho3020
Copy link
Copy Markdown
Contributor

@joonho3020 joonho3020 commented Oct 4, 2023

Pipe in https://github.com/firesim/icenet/blob/bbce029e3d3e4b11578f380ad48012fc49247d60/src/main/scala/NIC.scala#L603 is set on a different clock & reset domain than external ports of the NIC, causing the nic-loopback test to fail.

This PR fixes this by explicitly setting the clock & reset domain in the testharness for NIC loopbacks.

Related PRs / Issues:

Related PR

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123
Copy link
Copy Markdown
Contributor

Thanks!. CI is down until tomorrow. Let's wait until tomorrow to merge

@jerryz123
Copy link
Copy Markdown
Contributor

I'm doing a squash and merge here, since the bump+unbump could potentially cause merge conflicts

@jerryz123 jerryz123 merged commit a524adb into main Oct 6, 2023
@joonho3020 joonho3020 deleted the icenet-loopback-fix branch October 6, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants