Bump TestChipIp to improve default serial_tl behavior#1435
Merged
Conversation
b64cf76 to
ad9ea33
Compare
harrisonliew
approved these changes
Apr 17, 2023
T-K-233
approved these changes
Apr 17, 2023
Member
T-K-233
left a comment
There was a problem hiding this comment.
Is it possible to change the chip config order to:
class ChipLikeQuadRocketConfig extends Config(
// Set up TestHarness
// Set up I/O
// Set up tiles
// Set up clock./reset
)(io go after tiles)?
This way is cleaner, such that periphery devices (backing mem, uart, spi etc) are added after the core.
Contributor
Author
I think that should be fine, if you do it in another PR. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a special config fragment was necessary to prevent the chip from generating serial_tl packets during reset. Additionally, this was done using AsyncQueues, instead of just BlockDuringReset.
This changes all designs to block serial_tl while under reset
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?