Skip to content

bump testchipip#1434

Merged
jerryz123 merged 3 commits intomainfrom
bump-testchipip
Apr 10, 2023
Merged

bump testchipip#1434
jerryz123 merged 3 commits intomainfrom
bump-testchipip

Conversation

@joonho3020
Copy link
Copy Markdown
Contributor

Add SimTLMem in testchipip

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@joonho3020 joonho3020 requested a review from jerryz123 April 10, 2023 02:38
Copy link
Copy Markdown
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment on your testchipip PR.

Copy link
Copy Markdown
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI. Firesim on master is expected to fail

@jerryz123 jerryz123 merged commit 4f8ccc7 into main Apr 10, 2023
@jerryz123 jerryz123 deleted the bump-testchipip branch April 10, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants