Skip to content

Resolve merge conflicts in chisel3.5.6 bump#1430

Merged
jerryz123 merged 1 commit intomainfrom
chisel356fixes
Apr 8, 2023
Merged

Resolve merge conflicts in chisel3.5.6 bump#1430
jerryz123 merged 1 commit intomainfrom
chisel356fixes

Conversation

@jerryz123
Copy link
Copy Markdown
Contributor

@jerryz123 jerryz123 commented Apr 8, 2023

#1411 broke main with some merge conflicts. This fixes them

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@joonho3020
Copy link
Copy Markdown
Contributor

Looks good in first glance.

@jerryz123 jerryz123 merged commit 60468e1 into main Apr 8, 2023
@jerryz123 jerryz123 deleted the chisel356fixes branch April 8, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants