Skip to content

Add disallow packed arrays#1372

Merged
abejgonzalez merged 18 commits intomainfrom
add-disallowPackedArrays
Mar 9, 2023
Merged

Add disallow packed arrays#1372
abejgonzalez merged 18 commits intomainfrom
add-disallowPackedArrays

Conversation

@joonho3020
Copy link
Copy Markdown
Contributor

Add disallowPackedArrays flag back for compatibility with openroad tutorial flow.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@harrisonliew harrisonliew requested a review from nayiri-k March 1, 2023 18:52
@abejgonzalez
Copy link
Copy Markdown
Contributor

@Mergifyio rebase

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 2, 2023

rebase

❌ Base branch update has failed

Details

Git reported the following error:

Rebasing (1/2)
Rebasing (2/2)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git rebase --skip'
interactive rebase in progress; onto c0b2708
Last commands done (2 commands done):
   pick 30df6da add disallowPackedArrays
   pick 40ec17f bump barstools
No commands remaining.
You are currently rebasing branch 'add-disallowPackedArrays' on 'c0b2708'.
  (all conflicts fixed: run "git rebase --continue")

nothing to commit, working tree clean
Could not apply 40ec17f... bump barstools

err-code: A436E

@abejgonzalez
Copy link
Copy Markdown
Contributor

abejgonzalez commented Mar 2, 2023

@joey0320 can you drop the barstools commit from this PR since it was already bumped in another PR

Nevermind. I updated the commit in this PR to point to the latest main branch of barstools

@abejgonzalez abejgonzalez force-pushed the add-disallowPackedArrays branch from 40ec17f to af2a146 Compare March 2, 2023 17:30
@joonho3020
Copy link
Copy Markdown
Contributor Author

Oh, thanks

@abejgonzalez
Copy link
Copy Markdown
Contributor

Looks like there are issues with more complicated designs?

@abejgonzalez
Copy link
Copy Markdown
Contributor

@Mergifyio rebase

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 9, 2023

rebase

❌ Base branch update has failed

Details

Git reported the following error:

warning: skipped previously applied commit e3424f7
warning: skipped previously applied commit 317e0db
warning: skipped previously applied commit 817b6de
warning: skipped previously applied commit 4add9f7
warning: skipped previously applied commit 2acb986
warning: skipped previously applied commit c15a72d
hint: use --reapply-cherry-picks to include skipped commits
hint: Disable this message with "git config advice.skippedCherryPicks false"
Rebasing (1/9)
Rebasing (2/9)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git rebase --skip'
interactive rebase in progress; onto 0af8643
Last commands done (2 commands done):
   pick 30df6da add disallowPackedArrays
   pick 07b194e add disallowPackedArrays
Next commands to do (7 remaining commands):
   pick af2a146 bump barstools
   pick 3a53dc6 Add ENABLE_VLSI_FLOW flag
  (use "git rebase --edit-todo" to view and edit)
You are currently rebasing branch 'add-disallowPackedArrays' on '0af8643'.
  (all conflicts fixed: run "git rebase --continue")

nothing to commit, working tree clean
Could not apply 07b194e... add disallowPackedArrays

err-code: A8ED6

@abejgonzalez abejgonzalez reopened this Mar 9, 2023
@abejgonzalez abejgonzalez reopened this Mar 9, 2023
@abejgonzalez abejgonzalez reopened this Mar 9, 2023
@abejgonzalez abejgonzalez merged commit 8f06313 into main Mar 9, 2023
@jerryz123 jerryz123 deleted the add-disallowPackedArrays branch January 21, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants