Cache .ivy2 and .sbt within Chipyard root directory#1362
Merged
abejgonzalez merged 3 commits intomainfrom Mar 7, 2023
Merged
Conversation
Contributor
Author
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
32f33cd to
d8df375
Compare
jerryz123
approved these changes
Feb 28, 2023
Contributor
|
If things can fail when the dirs don't exist, then we should just commit the directories with an empty file so the git clone will always produce it. |
jerryz123
reviewed
Mar 1, 2023
cadf35e to
6ecd138
Compare
16 tasks
jerryz123
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
.ivy2and.sbtfolders are small under normal Chipyard circumstances (<150MBs), go ahead and store them within the Chipyard root directory. This further isolates separate Chipyard repos from one another (thisivy2sharing indirectly caused an issue where scala files would have no partial compilation). For those that want to overrideSBT_OPTS, they still can (as evidenced by the CI not changing - it still overrides the options). Additionally, this PR adds theSBT_OPTSon the command line so that the thin client can pick it up (fixes #1329).Finally, this resolves some minorbuild.sbtdeprecation warnings.Related PRs / Issues:
Fixes #1329
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?