Fix TestDriver.v missing from gen-collateral after recompiling#1354
Merged
Fix TestDriver.v missing from gen-collateral after recompiling#1354
Conversation
Contributor
Author
|
This PR also fixes #1355 |
joonho3020
force-pushed
the
fix-missing-testdriver
branch
from
e9ca635 to
32dfc6f
Compare
This reverts commit be35854.
jerryz123
reviewed
Feb 22, 2023
| cp -f $^ $(GEN_COLLATERAL_DIR) | ||
| $(sim_files): $(SIM_FILE_REQS) $(ALL_MODS_FILELIST) | $(GEN_COLLATERAL_DIR) | ||
| cp -f $(SIM_FILE_REQS) $(GEN_COLLATERAL_DIR) | ||
| $(foreach file,\ |
Contributor
There was a problem hiding this comment.
I'm happy to merge this like this, but I think this is only a temporary fix. The rules should still work if SIM_FILE_REQS is an empty list.
Contributor
Author
There was a problem hiding this comment.
Agreed, I kind of came up with the easiest fix that will work quickly
Contributor
There was a problem hiding this comment.
If this is blocking, let's merge this now. I found this issue as well and put this on my TODO list but I won't be able to get to this till afternoon tomorrow.
jerryz123
approved these changes
Feb 22, 2023
Contributor
jerryz123
left a comment
jerryz123
left a comment
There was a problem hiding this comment.
Let's merge this as soon as the CI passes, to unblock some other CI runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After removing the
$GEN_COLLATERAL_DIR,$(sim_files)are not getting copied back because their prereqs ($(SIM_FILE_REQS)) have not changed.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?