Skip to content

Remove Duplicate Compiler Flags#1351

Merged
joonho3020 merged 10 commits intomainfrom
rm-duplicate-compiler-anno
Feb 23, 2023
Merged

Remove Duplicate Compiler Flags#1351
joonho3020 merged 10 commits intomainfrom
rm-duplicate-compiler-anno

Conversation

@joonho3020
Copy link
Copy Markdown
Contributor

Related PRs / Issues:

This PR reverts ucb-bar/barstools#125.
Instead of exposing a duplicate annotation flag from barstools to perform ExtraPassesTransform, CY will provide barstools with json annotations when the ENABLE_CUSTOM_FIRRTL_PASS is set.

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@joonho3020 joonho3020 merged commit d5f6e56 into main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants