Skip to content

checkmake pre-commit hook#1310

Merged
joonho3020 merged 3 commits intomainfrom
checkmake-precommit
Jan 16, 2023
Merged

checkmake pre-commit hook#1310
joonho3020 merged 3 commits intomainfrom
checkmake-precommit

Conversation

@joonho3020
Copy link
Copy Markdown
Contributor

Add checkmake as pre-commit.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Copy Markdown
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@joonho3020
Copy link
Copy Markdown
Contributor Author

thxs for the review!

@joonho3020 joonho3020 merged commit 749f844 into main Jan 16, 2023
@jerryz123 jerryz123 deleted the checkmake-precommit branch February 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants