Conversation
abejgonzalez
approved these changes
Oct 10, 2022
Contributor
abejgonzalez
left a comment
There was a problem hiding this comment.
LGTM. Can you update FireSim + circular bump CY?
Contributor
Author
How does this affect firesim? I thought firesim ignored this makefile. |
Contributor
|
FireSim uses the CY build system if CY is top. However, if FSim-as-top is used then it uses its own build system. I assume a few people are using FSim-as-top so this issue would still occur for them. |
Contributor
Author
|
I can change this in firesim, but I don't think the flow in chipyard and the flow in firesim have to match (there doesn't need to be a circular bump), since the flows are independent. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in sbt/sbt#6468,
sbt --clientdoes not pass flags to the client. This causes the client to ignorejava.io.tmpdir, which breaks Chipyard usage on a shared machine.Revert to invoking
sbtthroughsbt-launch.jarRelated PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?