Skip to content

Revert to using sbt-launch.jar to run SBT#1251

Merged
jerryz123 merged 1 commit intomainfrom
javasbt
Oct 13, 2022
Merged

Revert to using sbt-launch.jar to run SBT#1251
jerryz123 merged 1 commit intomainfrom
javasbt

Conversation

@jerryz123
Copy link
Copy Markdown
Contributor

@jerryz123 jerryz123 commented Oct 10, 2022

As reported in sbt/sbt#6468, sbt --client does not pass flags to the client. This causes the client to ignore java.io.tmpdir, which breaks Chipyard usage on a shared machine.

Revert to invoking sbt through sbt-launch.jar

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Copy Markdown
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you update FireSim + circular bump CY?

@jerryz123
Copy link
Copy Markdown
Contributor Author

LGTM. Can you update FireSim + circular bump CY?

How does this affect firesim? I thought firesim ignored this makefile.

@abejgonzalez
Copy link
Copy Markdown
Contributor

abejgonzalez commented Oct 11, 2022

FireSim uses the CY build system if CY is top. However, if FSim-as-top is used then it uses its own build system. I assume a few people are using FSim-as-top so this issue would still occur for them.

@jerryz123
Copy link
Copy Markdown
Contributor Author

I can change this in firesim, but I don't think the flow in chipyard and the flow in firesim have to match (there doesn't need to be a circular bump), since the flows are independent.

@jerryz123 jerryz123 merged commit d0ce14a into main Oct 13, 2022
@jerryz123 jerryz123 deleted the javasbt branch January 6, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants