New deployment strategy #1682
Merged
New deployment strategy #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances deployment reliability by introducing comprehensive health checks, automated rollback strategies, and improved TLS certificate management for both production and staging environments.
Key Changes:
- Added health checks for memcached, django, and nginx services with automatic failure detection and recovery
- Implemented rollback configurations for django and nginx services to revert failed deployments
- Automated TLS certificate renewal with nginx reload functionality through a dedicated certbot service script
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/sync-secrets.sh |
New script to synchronize secrets from Google Secret Manager to Docker secrets |
scripts/certbot-renewal-with-nginx-reload.sh |
New script that continuously monitors certificate renewals and reloads nginx after each check |
scripts/certbot-init.sh |
New initialization script for obtaining initial SSL certificates for production and staging domains |
docker-compose.yml |
Added health checks for memcached, django, and nginx; configured rollback strategies and restart policies; updated certbot service to use new renewal script with docker socket access |
.github/workflows/deploy-staging.yml |
Updated to upload certbot renewal script and corrected path for sync-secrets.sh script |
.github/workflows/deploy-production.yml |
Updated to upload certbot renewal script and corrected path for sync-secrets.sh script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
psiemens
reviewed
Nov 25, 2025
.github/workflows/deploy-staging.yml
Outdated
| on: | ||
| push: | ||
| branches: | ||
| - new-deployment-strategy |
Member
There was a problem hiding this comment.
Just a reminder to remove this before merging.
.github/workflows/deploy-staging.yml
Outdated
| deploy: | ||
| # Only run if the production build job was successful | ||
| if: ${{ github.event.workflow_run.conclusion == 'success' }} | ||
| # Run on push to new-deployment-strategy branch OR if production build was successful |
| @@ -0,0 +1,33 @@ | |||
| #!/bin/sh | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces service reliability for both production and staging environments. The main changes include enhanced health checks for core services, added rollback strategies, automation of TLS certificate renewal with nginx reloads.
Deployment Workflow Improvements
certbot-renewal-with-nginx-reload.shscript during both production and staging deployments, ensuring automated certificate renewal and nginx reload.Service Reliability Enhancements
memcached,django, andnginxservices indocker-compose.ymlto automatically detect and recover from failures, preventing silent deployment of broken configurations.django,nginx, andcertbotservices, ensuring services recover from failures and roll back on unsuccessful updates.