fix(a11y): improve app card accessibility for screen readers (#1586)#2056
Open
gauravsaini wants to merge 1 commit intoubuntu:mainfrom
Open
fix(a11y): improve app card accessibility for screen readers (#1586)#2056gauravsaini wants to merge 1 commit intoubuntu:mainfrom
gauravsaini wants to merge 1 commit intoubuntu:mainfrom
Conversation
- Fix app card screen reader support by simplifying semantics structure (ubuntu#1586) - Make app icon excluded from semantics to avoid duplicate 'Image' announcement - Set button property based on onTap availability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
MergeSemanticswrapper which was causing issues with some screen readersonTaptoSemanticswidget for proper button behaviorbuttonproperty based on whetheronTapis available