fix: parse channel parameter from snap:// URLs (#1982)#2053
Open
gauravsaini wants to merge 1 commit intoubuntu:mainfrom
Open
fix: parse channel parameter from snap:// URLs (#1982)#2053gauravsaini wants to merge 1 commit intoubuntu:mainfrom
gauravsaini wants to merge 1 commit intoubuntu:mainfrom
Conversation
When opening snap:// URLs with a channel parameter (e.g., snap://gimp?channel=preview/stable), the channel is now properly extracted and the snap page opens with the correct channel selected. Changes: - Parse URLs using Uri.parse to properly extract query parameters - Add channelOf method to StoreRoutes - Add channel parameter to namedSnap method - Pass channel from route to SnapPage - Select the specified channel when snap data loads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snap://URLs usingUri.parseto extract snap name and query parameterschannelparameter in snap URLs (e.g.,snap://gimp?channel=preview/stable)snap://snap_name?channel=non_latest_track#1982Problem
When opening a
snap://URL with a channel parameter from snapcraft.io (e.g.,snap://gimp?channel=preview/stable), the entire string aftersnap://was being used as the snap name, causing "Something went wrong" error.Changes
store_providers.dart: UseUri.parseto properly extract snap name and channel parameterstore_routes.dart: AddchannelOfmethod andchannelparameter tonamedSnapstore_app.dart: Pass channel from route toSnapPagesnap_page.dart: Accept channel parameter and select it when snap data loadsTesting