Conversation
| if (debModel.activeTransactionId != null) cancelButton, | ||
| if (debModel.activeTransactionId != null) ...[ | ||
| const SizedBox(width: kSpacing), | ||
| cancelButton, |
Member
There was a problem hiding this comment.
Not part of your pr, but I've just noticed we aren't clearing the transaction ID when we cancel a deb install, so you get stuck in this state if you cancel an install / cancel the polkit prompt:
Member
There was a problem hiding this comment.
But this isn't a regression, so wont block your PR on it 🙂
This is similar to what is present on Snap pages
These could probably use revisiting later
ashuntu
force-pushed
the
deb-action-buttons
branch
from
b7fba00 to
b294994
Compare
matthew-hagemann
approved these changes
Mar 19, 2026
ashuntu
added a commit
that referenced
this pull request
Mar 24, 2026
Clears transaction ID when cancelling via the cancel button or when an error occurs (i.e. authorization fails). This fixes an issue where the loading icon is always displayed, even when errors happen or the action is cancelled. Related #2047 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganizes deb action buttons to have more consistent layout and spacing with snap pages. Moves the Uninstall action under the more actions button.
Also fixes an issue where the update button wasn't appearing under the right circumstances.
This should basically be the last of the deb page updates apart from bug fixes that have previously existed.
UDENG-9432