Make NGitLab.Mock.Clients.ClientContext lock async-friendly
#910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-z
force-pushed
the
remove-lock-from-mocks-clientcontext
branch
2 times, most recently
from
7ca8a1f to
da09093
Compare
louis-z
changed the title
async-friendly
louis-z
force-pushed
the
remove-lock-from-mocks-clientcontext
branch
2 times, most recently
from
1dc2da2 to
7a054ea
Compare
That lock mechanism was not needed and caused issues when using the ClientContext in an async context.
louis-z
force-pushed
the
remove-lock-from-mocks-clientcontext
branch
from
7a054ea to
e4f21fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locking mechanism was reported as throwing a
System.Threading.SynchronizationLockExceptionwhen used in anasynccontext. This is because continuation of anawaited Task may occur on a different thread than the initial one, which means an attempt to release the lock from a different thread than the one that "owns" it.NGitLab.Mock.Tests.FileTeststo reproduce the issueBut wait, is that locking scheme even required? Let's remove it and see what happens...